Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SVG #389

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Add support for SVG #389

merged 1 commit into from
Mar 17, 2022

Conversation

lukechu10
Copy link
Member

Closes #288

@lukechu10 lukechu10 added C-enhancement Category: new feature or improvement to existing feature BREAKING CHANGE Breaking changes introduced in this PR labels Mar 17, 2022
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #389 (dd838f2) into master (c3a6ba4) will decrease coverage by 0.28%.
The diff coverage is 49.09%.

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
- Coverage   63.55%   63.26%   -0.29%     
==========================================
  Files          47       47              
  Lines        7693     7725      +32     
==========================================
- Hits         4889     4887       -2     
- Misses       2804     2838      +34     
Impacted Files Coverage Δ
packages/sycamore/src/generic_node/dom_node.rs 0.00% <0.00%> (ø)
packages/sycamore/src/generic_node/hydrate_dom.rs 0.00% <0.00%> (ø)
packages/sycamore/src/generic_node/mod.rs 100.00% <ø> (ø)
packages/sycamore/src/builder.rs 24.07% <50.00%> (ø)
packages/sycamore/src/generic_node/ssr_node.rs 76.44% <91.66%> (-2.28%) ⬇️
packages/sycamore-macro/src/view/codegen.rs 95.98% <100.00%> (-0.03%) ⬇️
packages/sycamore/src/noderef.rs 77.96% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3a6ba4...dd838f2. Read the comment docs.

@lukechu10 lukechu10 merged commit 923feeb into master Mar 17, 2022
@lukechu10 lukechu10 deleted the view-svg-support branch March 17, 2022 18:46
@lukechu10 lukechu10 added this to the v0.8 milestone Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE Breaking changes introduced in this PR C-enhancement Category: new feature or improvement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SVG Support
1 participant