-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add .inner_html() builder method #378
Conversation
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
- Coverage 64.99% 64.84% -0.16%
==========================================
Files 52 52
Lines 8305 8325 +20
==========================================
Hits 5398 5398
- Misses 2907 2927 +20
Continue to review full report at Codecov.
|
I guess this relates to #288 - we have tried a few things in 0.7-land, like:
Since this patch is tiny, we might backport it to 0.7 as well, so I can see how it feels when used with our existing codebase. That way, we give an experience report. |
Is it just the function name change that is blocking this from being merged? :) |
Sorry haven't taken a look in this in a while. It's that and also I'd like to keep the example the way it is right now to be consistent with the non-builder equivalent. I can push a commit on my side to fix that and merge this soon. |
This is useful for injecting SVGs into the dom.
I have not tested this with SSR or hydration, because I'm not using them in my current project.