Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix top-level dynamics nodes with hydration #374

Merged
merged 4 commits into from
Mar 6, 2022

Conversation

lukechu10
Copy link
Member

Fixes #319

@lukechu10 lukechu10 added C-bug Category: bug, something isn't working A-hydration Area: client-side hydration labels Mar 6, 2022
@codecov
Copy link

codecov bot commented Mar 6, 2022

Codecov Report

Merging #374 (9f89ce6) into master (8b2beb5) will increase coverage by 1.02%.
The diff coverage is 42.85%.

❗ Current head 9f89ce6 differs from pull request most recent head a3f50de. Consider uploading reports for the commit a3f50de to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   62.66%   63.68%   +1.02%     
==========================================
  Files          47       47              
  Lines        7658     7678      +20     
==========================================
+ Hits         4799     4890      +91     
+ Misses       2859     2788      -71     
Impacted Files Coverage Δ
packages/sycamore/src/generic_node/hydrate_dom.rs 0.00% <0.00%> (ø)
packages/sycamore/src/builder.rs 24.39% <100.00%> (+24.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b2beb5...a3f50de. Read the comment docs.

@lukechu10 lukechu10 marked this pull request as draft March 6, 2022 04:58
@lukechu10 lukechu10 marked this pull request as ready for review March 6, 2022 16:35
BREAKING CHANGE: rename experimental-builder-agnostic to builder
@lukechu10 lukechu10 enabled auto-merge (squash) March 6, 2022 17:05
@lukechu10 lukechu10 merged commit 879501d into master Mar 6, 2022
@lukechu10 lukechu10 deleted the fix-top-level-dyn-hydration branch March 6, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-hydration Area: client-side hydration C-bug Category: bug, something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydration duplicates interpolated variables
1 participant