-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactive Primitives v2! 🎉 #337
Conversation
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
- Coverage 73.15% 64.46% -8.70%
==========================================
Files 40 46 +6
Lines 5435 6956 +1521
==========================================
+ Hits 3976 4484 +508
- Misses 1459 2472 +1013
Continue to review full report at Codecov.
|
This change is required, first of all, to satisfy bumpalo whose MSRV is 1.54.0, second of all, because edition 2021 support is required for new reactivity system.
Bug in wasm-bindgen codegen triggering clippy lint
See description of create_child_scope_tracked
Started a benchmark for this pull request. Workflow: 1759843281 |
This is no longer needed now that the soundness bug regarding signals that are destroyed before effects complete is fixed.
Maybe it's because of edition 2021?
Congratulations and many thanks @lukechu10 for all your hard work on this! |
Gets rid of all the clones!
Closes #107
Task list:
(some of these might get split up into separate PRs)
sycamore-router
Portal
sycamore-reactive
because of all theunsafe
code