Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive Primitives v2! 🎉 #337

Merged
merged 29 commits into from
Jan 30, 2022
Merged

Reactive Primitives v2! 🎉 #337

merged 29 commits into from
Jan 30, 2022

Conversation

lukechu10
Copy link
Member

@lukechu10 lukechu10 commented Jan 26, 2022

Gets rid of all the clones!

Closes #107

Task list:

(some of these might get split up into separate PRs)

  • Port sycamore-router
  • Port website
  • Port SSR benchmark
  • Port Portal
  • Port tweening and motion
  • Update docs
  • Add more tests for sycamore-reactive because of all the unsafe code

@lukechu10 lukechu10 added A-reactivity Area: reactivity and state handling BREAKING CHANGE Breaking changes introduced in this PR A-ergonomics Area: API ergonomics labels Jan 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

Merging #337 (aab8a71) into master (619c300) will decrease coverage by 8.69%.
The diff coverage is 73.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
- Coverage   73.15%   64.46%   -8.70%     
==========================================
  Files          40       46       +6     
  Lines        5435     6956    +1521     
==========================================
+ Hits         3976     4484     +508     
- Misses       1459     2472    +1013     
Impacted Files Coverage Δ
packages/sycamore/src/easing.rs 95.93% <ø> (-0.07%) ⬇️
packages/sycamore/src/futures.rs 0.00% <0.00%> (ø)
packages/sycamore/src/generic_node/dom_node.rs 0.00% <0.00%> (ø)
packages/sycamore/src/generic_node/hydrate_dom.rs 0.00% <0.00%> (ø)
packages/sycamore/src/generic_node/mod.rs 0.00% <ø> (-100.00%) ⬇️
packages/sycamore/src/lib.rs 100.00% <ø> (ø)
packages/sycamore/src/motion.rs 0.00% <0.00%> (ø)
packages/sycamore/src/portal.rs 0.00% <0.00%> (ø)
packages/sycamore/src/utils/hydrate/web.rs 0.00% <0.00%> (ø)
website/src/content.rs 0.00% <0.00%> (ø)
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56e8f04...aab8a71. Read the comment docs.

@lukechu10 lukechu10 added the performance Performance related label Jan 28, 2022
@github-actions
Copy link

Started a benchmark for this pull request.
This comment will be updated with the results.

Workflow: 1759843281
Adding new commits will generate a new report

@lukechu10 lukechu10 removed the performance Performance related label Jan 28, 2022
@lukechu10 lukechu10 marked this pull request as ready for review January 29, 2022 03:51
This is no longer needed now that the soundness bug regarding signals that are destroyed before effects complete is fixed.
Maybe it's because of edition 2021?
@lukechu10 lukechu10 merged commit ca56171 into master Jan 30, 2022
@lukechu10 lukechu10 deleted the reactive-v2 branch January 30, 2022 04:12
@arctic-hen7
Copy link
Contributor

Congratulations and many thanks @lukechu10 for all your hard work on this!

@lukechu10 lukechu10 added this to the v0.8 milestone Jun 8, 2022
@lukechu10 lukechu10 mentioned this pull request May 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ergonomics Area: API ergonomics A-reactivity Area: reactivity and state handling BREAKING CHANGE Breaking changes introduced in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component children
3 participants