Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter phantom_generics to contain types only #312

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Filter phantom_generics to contain types only #312

merged 1 commit into from
Dec 7, 2021

Conversation

danielalvsaaker
Copy link
Contributor

Fixes #311.

@codecov-commenter
Copy link

Codecov Report

Merging #312 (136690a) into master (7738584) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   73.21%   73.28%   +0.07%     
==========================================
  Files          38       38              
  Lines        5313     5320       +7     
==========================================
+ Hits         3890     3899       +9     
+ Misses       1423     1421       -2     
Impacted Files Coverage Δ
packages/sycamore-macro/src/component/mod.rs 76.25% <100.00%> (+0.78%) ⬆️
packages/sycamore-reactive/src/effect.rs 91.30% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7738584...136690a. Read the comment docs.

Copy link
Member

@lukechu10 lukechu10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukechu10 lukechu10 merged commit 0c62e70 into sycamore-rs:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Const generic component compile error
3 participants