Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #[track_caller] for use_context #306

Merged
merged 1 commit into from
Nov 28, 2021
Merged

Conversation

lukechu10
Copy link
Member

This makes it much easier to debug "context not found for type" errors.

@lukechu10 lukechu10 added A-ergonomics Area: API ergonomics A-context labels Nov 28, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #306 (71a6d2e) into master (31050ae) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
+ Coverage   72.70%   72.73%   +0.03%     
==========================================
  Files          38       38              
  Lines        5143     5146       +3     
==========================================
+ Hits         3739     3743       +4     
+ Misses       1404     1403       -1     
Impacted Files Coverage Δ
packages/sycamore-reactive/src/context.rs 89.18% <100.00%> (+0.95%) ⬆️
packages/sycamore-reactive/src/lib.rs 95.31% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31050ae...71a6d2e. Read the comment docs.

@lukechu10 lukechu10 merged commit 4663c7c into master Nov 28, 2021
@lukechu10 lukechu10 deleted the use-context-track-caller branch November 28, 2021 23:32
attriaayush pushed a commit to attriaayush/sycamore that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ergonomics Area: API ergonomics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants