Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename StateHandle to ReadSignal #300

Merged
merged 2 commits into from
Nov 13, 2021
Merged

Rename StateHandle to ReadSignal #300

merged 2 commits into from
Nov 13, 2021

Conversation

lukechu10
Copy link
Member

Closes #299

@lukechu10 lukechu10 added C-enhancement Category: new feature or improvement to existing feature BREAKING CHANGE Breaking changes introduced in this PR labels Nov 13, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2021

Codecov Report

Merging #300 (e6822bb) into master (6dd47f4) will not change coverage.
The diff coverage is 90.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   75.00%   75.00%           
=======================================
  Files          33       33           
  Lines        4797     4797           
=======================================
  Hits         3598     3598           
  Misses       1199     1199           
Impacted Files Coverage Δ
packages/sycamore-router/src/router.rs 25.76% <ø> (ø)
packages/sycamore/src/flow.rs 50.00% <ø> (ø)
packages/sycamore/src/lib.rs 100.00% <ø> (ø)
packages/sycamore/src/view.rs 66.03% <ø> (ø)
website/src/main.rs 0.98% <0.00%> (ø)
packages/sycamore-reactive/src/effect.rs 92.09% <100.00%> (ø)
packages/sycamore-reactive/src/iter.rs 97.81% <100.00%> (ø)
packages/sycamore-reactive/src/signal.rs 69.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dd47f4...e6822bb. Read the comment docs.

@lukechu10 lukechu10 merged commit 8634331 into master Nov 13, 2021
@lukechu10 lukechu10 deleted the read-signal branch November 13, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE Breaking changes introduced in this PR C-enhancement Category: new feature or improvement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename StateHandle to ReadSignal
2 participants