Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Template to View #298

Merged
merged 7 commits into from
Nov 6, 2021
Merged

Rename Template to View #298

merged 7 commits into from
Nov 6, 2021

Conversation

lukechu10
Copy link
Member

Closes #266

@lukechu10 lukechu10 added BREAKING CHANGE Breaking changes introduced in this PR A-ergonomics Area: API ergonomics labels Nov 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2021

Codecov Report

Merging #298 (bd68b33) into master (f444a5f) will increase coverage by 0.06%.
The diff coverage is 62.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
+ Coverage   74.93%   75.00%   +0.06%     
==========================================
  Files          33       33              
  Lines        4800     4796       -4     
==========================================
  Hits         3597     3597              
+ Misses       1203     1199       -4     
Impacted Files Coverage Δ
packages/sycamore-macro/src/component/mod.rs 73.86% <0.00%> (ø)
packages/sycamore-macro/src/view/attributes.rs 92.75% <ø> (ø)
packages/sycamore-macro/src/view/children.rs 100.00% <ø> (ø)
packages/sycamore-macro/src/view/component.rs 64.00% <ø> (ø)
packages/sycamore-macro/src/view/splice.rs 100.00% <ø> (ø)
packages/sycamore/src/generic_node/dom_node.rs 0.00% <0.00%> (ø)
packages/sycamore/src/lib.rs 100.00% <ø> (ø)
packages/sycamore/src/portal.rs 0.00% <ø> (ø)
website/src/main.rs 0.98% <0.00%> (ø)
packages/sycamore/src/flow.rs 50.00% <50.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f444a5f...bd68b33. Read the comment docs.

@lukechu10 lukechu10 marked this pull request as ready for review November 6, 2021 22:04
@lukechu10 lukechu10 merged commit 3ecf86a into master Nov 6, 2021
@lukechu10 lukechu10 deleted the rename-template-to-view branch November 6, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ergonomics Area: API ergonomics BREAKING CHANGE Breaking changes introduced in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Template to View
2 participants