Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GenericNode generic over the event type #297

Merged
merged 3 commits into from
Nov 6, 2021
Merged

Conversation

lukechu10
Copy link
Member

@lukechu10 lukechu10 commented Nov 6, 2021

This allows creating rendering backends that do not use web_sys::Event in event handlers

@lukechu10 lukechu10 added C-enhancement Category: new feature or improvement to existing feature BREAKING CHANGE Breaking changes introduced in this PR labels Nov 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2021

Codecov Report

Merging #297 (7436d0c) into master (d17e776) will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #297   +/-   ##
=======================================
  Coverage   74.93%   74.93%           
=======================================
  Files          33       33           
  Lines        4800     4800           
=======================================
  Hits         3597     3597           
  Misses       1203     1203           
Impacted Files Coverage Δ
packages/sycamore-router/src/router.rs 25.76% <0.00%> (ø)
packages/sycamore/src/generic_node/dom_node.rs 0.00% <0.00%> (ø)
packages/sycamore/src/generic_node/ssr_node.rs 76.45% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d17e776...7436d0c. Read the comment docs.

@lukechu10 lukechu10 merged commit f444a5f into master Nov 6, 2021
@lukechu10 lukechu10 deleted the generic-event branch November 6, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE Breaking changes introduced in this PR C-enhancement Category: new feature or improvement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants