Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TodoMVC example to use Context API #295

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

haywoood
Copy link
Contributor

@haywoood haywoood commented Nov 6, 2021

Does what it says on the tin, and it's so beautiful 😭

Closes #279

Does what it says on the tin.

Closes sycamore-rs#279
@lukechu10
Copy link
Member

Wow that was fast. Thanks a lot. Busy right now but will review soon

@codecov-commenter
Copy link

Codecov Report

Merging #295 (3a2b392) into master (f230127) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   75.23%   75.23%           
=======================================
  Files          33       33           
  Lines        4781     4781           
=======================================
  Hits         3597     3597           
  Misses       1184     1184           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f230127...3a2b392. Read the comment docs.

Copy link
Member

@lukechu10 lukechu10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

@lukechu10 lukechu10 merged commit d4c2469 into sycamore-rs:master Nov 6, 2021
@haywoood haywoood deleted the use_context_refactor branch December 27, 2021 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update TodoMVC example to use Context API
3 participants