Refactor effect dependency tracking #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukechu10
added
C-bug
This was referenced Mar 9, 2021
Closed
Make Signal a normal struct rather than a tuple struct
lukechu10
force-pushed
the
refactor-reactive
branch
from
1f05df3 to
4b89cf4
Compare
3 tasks
lukechu10
force-pushed
the
refactor-reactive
branch
from
ad2a562 to
2ff9f1f
Compare
commit b61242a Author: Luke Chu <[email protected]> Date: Tue Mar 9 22:14:18 2021 -0800 Create CODE_OF_CONDUCT.md (#33) commit e5dddbc Author: Kestrer <[email protected]> Date: Tue Mar 9 18:44:56 2021 +0000 Remove double-boxing of Computation (#31)
|
This PR breaks basic cycle detection. Cycle detection was not completely working anyways and will be tricky to implement with dynamic dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27 and #28