Added node! convenience macro #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquesada2016
force-pushed
the
master
branch
from
9c2785a to
e921d9a
Compare
|
Applied suggested changes! |
|
The diff has some commits that are not supposed to be there. If you don't mind, I can fix this and I'll get this merged |
jquesada2016
force-pushed
the
master
branch
from
4a85da4 to
d1b4eb4
Compare
|
I removed all commits that weren't supposed to be there. It was the 0.6.1 release that I pulled in. If there's still something that isn't supposed to be there, go right ahead! |
Closed
|
Sorry for the run-around but it seems like my suggested changes got undone. |
|
No worries! Let me know what you would like me to do in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This macro works well for cases where we need access to underlying
GenericNodeoperations, such as.event(),.add_attribute(),.remove_attributethat cannot currently be performed inside of thetemplate!macro, yet retain the ergonomics for setting attributes and children that don't need the extra flexibility. Please see thedoc examplebelow for a possible use case.This is also a good workaround for #264.