Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to use boolean for disabled attribute on button #248

Merged
merged 2 commits into from
Sep 18, 2021

Conversation

redian
Copy link
Contributor

@redian redian commented Sep 17, 2021

Going through docs came across this
and Rust compiler complained, hence this update.

Screenshot 2021-09-17 at 16 36 24

@lukechu10
Copy link
Member

Thanks for the contribution! BTW, I reverted the change on v0.5 docs because this is specific to v0.6

@lukechu10 lukechu10 enabled auto-merge (squash) September 18, 2021 18:23
@lukechu10 lukechu10 disabled auto-merge September 18, 2021 18:51
@lukechu10 lukechu10 merged commit f59b7fb into sycamore-rs:master Sep 18, 2021
simonchatts pushed a commit to simonchatts/sycamore that referenced this pull request Sep 19, 2021
…-rs#248)

* Update docs to use boolean for disabled attribute on button

* Do not modify docs for v0.5

Co-authored-by: Luke Chu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants