Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline JS snippet #194

Merged
merged 6 commits into from
Aug 4, 2021
Merged

Remove inline JS snippet #194

merged 6 commits into from
Aug 4, 2021

Conversation

lukechu10
Copy link
Member

No description provided.

@lukechu10 lukechu10 added the performance Performance related label Jul 31, 2021
@lukechu10 lukechu10 added performance Performance related and removed performance Performance related labels Jul 31, 2021
@sycamore-rs sycamore-rs deleted a comment from github-actions bot Jul 31, 2021
@sycamore-rs sycamore-rs deleted a comment from github-actions bot Jul 31, 2021
@sycamore-rs sycamore-rs deleted a comment from github-actions bot Jul 31, 2021
@sycamore-rs sycamore-rs deleted a comment from github-actions bot Aug 2, 2021
@sycamore-rs sycamore-rs deleted a comment from github-actions bot Aug 2, 2021
@sycamore-rs sycamore-rs deleted a comment from github-actions bot Aug 2, 2021
@sycamore-rs sycamore-rs deleted a comment from github-actions bot Aug 2, 2021
@sycamore-rs sycamore-rs deleted a comment from github-actions bot Aug 2, 2021
@sycamore-rs sycamore-rs deleted a comment from github-actions bot Aug 2, 2021
@lukechu10 lukechu10 added performance Performance related and removed performance Performance related labels Aug 2, 2021
@lukechu10 lukechu10 added performance Performance related and removed performance Performance related labels Aug 3, 2021
@sycamore-rs sycamore-rs deleted a comment from github-actions bot Aug 4, 2021
@sycamore-rs sycamore-rs deleted a comment from github-actions bot Aug 4, 2021
@sycamore-rs sycamore-rs deleted a comment from github-actions bot Aug 4, 2021
@github-actions
Copy link

github-actions bot commented Aug 4, 2021

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
  01_run1k               |       106.97 |   133.24 |  129.92 |   -2.49%
+ 02_replace1k           |       125.17 |   153.09 |  148.01 |   -3.32%
- 03_update10th1k_x16    |       299.30 |   278.54 |  318.58 |  +14.37%
+ 04_select1k            |        47.29 |    58.08 |   54.70 |   -5.82%
+ 05_swap1k              |        75.58 |    80.72 |   72.19 |  -10.58%
+ 06_remove-one-1k       |        25.88 |    27.48 |   26.14 |   -4.88%
  07_create10k           |      1052.79 |  1382.42 | 1385.36 |   +0.21%
  08_create1k-after1k_x2 |       249.91 |   296.92 |  290.78 |   -2.07%
  09_clear1k_x8          |       175.91 |   194.47 |  191.39 |   -1.58%
  21_ready-memory        |         1.03 |     1.02 |    1.02 |   -0.14%
  22_run-memory          |         1.51 |     1.81 |    1.81 |   -0.07%
  23_update5-memory      |         1.83 |     2.10 |    2.10 |   -0.07%
  24_run5-memory         |         2.11 |     2.36 |    2.35 |   -0.18%
  25_run-clear-memory    |         2.25 |     2.27 |    2.27 |   -0.07%
  31_startup-ci          |      1820.83 |  2037.31 | 2029.68 |   -0.37%
- 32_startup-bt          |        61.10 |    73.71 |  102.31 |  +38.81%
  34_startup-totalbytes  |       197.35 |   307.25 |  306.68 |   -0.19%

Workflow: 1099412159
Adding new commits will generate a new report

@lukechu10 lukechu10 removed the performance Performance related label Aug 4, 2021
@lukechu10 lukechu10 added the performance Performance related label Aug 4, 2021
@github-actions
Copy link

github-actions bot commented Aug 4, 2021

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
  01_run1k               |       101.27 |   128.58 |  126.98 |   -1.24%
  02_replace1k           |       115.22 |   140.74 |  138.02 |   -1.93%
  03_update10th1k_x16    |       235.77 |   242.52 |  244.39 |   +0.77%
  04_select1k            |        34.71 |    44.52 |   45.52 |   +2.24%
  05_swap1k              |        65.28 |    66.69 |   66.91 |   +0.33%
  06_remove-one-1k       |        24.39 |    24.83 |   24.77 |   -0.25%
  07_create10k           |      1025.87 |  1356.87 | 1357.50 |   +0.05%
  08_create1k-after1k_x2 |       233.09 |   267.37 |  266.33 |   -0.39%
- 09_clear1k_x8          |       166.31 |   175.08 |  185.18 |   +5.77%
  21_ready-memory        |         1.03 |     1.02 |    1.02 |   -0.16%
  22_run-memory          |         1.51 |     1.81 |    1.81 |   -0.06%
  23_update5-memory      |         1.83 |     2.10 |    2.10 |   -0.06%
  24_run5-memory         |         2.11 |     2.36 |    2.36 |   -0.17%
  25_run-clear-memory    |         2.25 |     2.27 |    2.27 |   -0.06%
  31_startup-ci          |      1819.74 |  2051.56 | 1993.28 |   -2.84%
- 32_startup-bt          |        52.34 |    89.29 |  117.69 |  +31.80%
  34_startup-totalbytes  |       197.35 |   307.25 |  306.68 |   -0.19%

Workflow: 1099444311
Adding new commits will generate a new report

@lukechu10 lukechu10 merged commit 8d4f383 into master Aug 4, 2021
@lukechu10 lukechu10 deleted the remove-inline-js branch August 4, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant