Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for enhancements/fixes #1

Closed
ehan03 opened this issue Jan 7, 2025 · 4 comments
Closed

Suggestions for enhancements/fixes #1

ehan03 opened this issue Jan 7, 2025 · 4 comments

Comments

@ehan03
Copy link

ehan03 commented Jan 7, 2025

  • Set a realistic but generous maximum on num_people, the app slows to a crawl with large numbers
  • Implement basic checks on num_tax with respect to num_subtotal, e.g. will never be more than xx% of the subtotal (this is a good sanity check after a night of drinking)
  • Same with num_tip, but % restrictions wouldn't apply here so probably not a must
  • Check that sum of each person's item total equals the subtotal, currently you can put values that far exceed the subtotal for any individual person
  • Maybe a way to input names of people in the party to avoid confusion over person 1, ..., n?
@swooshoo
Copy link
Owner

swooshoo commented Jan 7, 2025

  • Was considering a people limit, thanks for the feedback.
  • I also did include a basic check on num_tax where tax cannot be equal or greater to num_subtotal, but definitely could be flushed out more.
  • tip check - could be flushed out more.
  • this is a good issue, thank you for feedback.
  • i was considering naming by person but didn't get that far.

swooshoo added a commit that referenced this issue Jan 7, 2025
@swooshoo
Copy link
Owner

swooshoo commented Jan 7, 2025

#1: Implemented a 15-way split limit.

@ehan03
Copy link
Author

ehan03 commented Jan 7, 2025

cool. also if you don't want your app to fall asleep, you can set up a github actions workflow to send a GET request once a day with cURL or python requests to create artificial traffic

@swooshoo
Copy link
Owner

swooshoo commented Jan 7, 2025

I did not know that, that would actually be baller. Thanks for the suggestion.

swooshoo added a commit that referenced this issue Jan 7, 2025
#1: Python requests for artificial traffic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants