Upgrade node to v16 #137
Upgrade node to v16 #137
Conversation
Deploying with
|
| Latest commit: |
1dcb2b4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4577afb1.swim-ui.pages.dev |
| Branch Preview URL: | https://upgrade-dependencies.swim-ui.pages.dev |
|
✨ Deployment complete! Take a peek over at https://aeca52af.ui-storybook.pages.dev |
nicomiicro
requested review from
wormat,
arvakr,
cyphertrace,
ramenuncle and
fisprak
| @@ -0,0 +1,9 @@ | |||
| /* eslint-disable */ | |||
There was a problem hiding this comment.
Should this file be in .gitignore ?
There was a problem hiding this comment.
Nope it seems this is the way yarn plugins work, you install it and it's part of your source in a way, see https://github.com/swim-io/swim/blob/master/.gitignore#L6-L13
There was a problem hiding this comment.
Ah ok, I had the same on my PR, just saw that :D
| @@ -9,9 +11,9 @@ plugins: | |||
| spec: "@yarnpkg/plugin-workspace-tools" | |||
| - path: .yarn/plugins/@yarnpkg/plugin-version.cjs | |||
| spec: "@yarnpkg/plugin-version" | |||
| - path: .yarn/plugins/@yarnpkg/plugin-engines.cjs | |||
| spec: "https://raw.githubusercontent.com/devoto13/yarn-plugin-engines/main/bundles/%40yarnpkg/plugin-engines.js" | |||
There was a problem hiding this comment.
Nice. Noting this here from the README:
With Yarn 1 one can set engines.node field in the project's package.json to communicate the required Node version, but this feature is yarnpkg/berry#1177. Hopefully one day this will be implemented in Yarn core making the plugin obsolete.
| @@ -60,7 +60,7 @@ | |||
| "immer": "^9.0.14", | |||
| "moment": "^2.29.1", | |||
| "moralis": "^1.3.5", | |||
| "node-sass": "^4.12.0", | |||
| "node-sass": "^6", | |||
Description
PR Checklist
Post Review Checklist
Is there a ticket for this change? If yes, please paste the notion link below
Notion link: https://www.notion.so/exsphere/Monthly-dependencies-upgrade-f92aeba4676b4fa9b1a2bb359240a746