[Preset] include sourcekit-inproc in default install on Linux

[norio-nomura]

Resolves SR-3699.

Is there any reason to not do this yet?

[alblue]

@swift-ci please test

[alblue]

There's no particular reason why this can't be done, but I haven't tested it yet with one of the build presets that packages up the instance. I'll try and build this tomorrow on my Ubuntu and Darwin boxes to verify that it doesn't have any unforseen issues.

[norio-nomura]

Ah, we should configure sourcekitdInProc to having RPATH.

[norio-nomura]

I added a commit that configure RPATH for loading libdispatch.so in relative path.

[alblue]

@swift-ci please test

[norio-nomura]

As a result of doing some verifications, I came to the conclusion that I can not use it as it is.
The following workarounds seem to be necessary for proper operation.

ln -s /usr/lib/sourcekitdInProc.framework/sourcekitdInProc /usr/lib/libsourcekitdInProc.so

It seems necessary to change the installation destination on Linux.

[alblue]

There's probably an easy fix somewhere to solve the installation path without needing a symlink. I'll have a look and see but if you can find/test as well that would be great. Alex Sent from my iPhone 📱

…

On 29 Mar 2017, at 08:50, Norio Nomura ***@***.***> wrote: As a result of doing some verifications, I came to the conclusion that I can not use it as it is. The following workarounds seem to be necessary for proper operation. ln -s /usr/lib/sourcekitdInProc.framework/sourcekitdInProc /usr/lib/libsourcekitdInProc.so It seems necessary to change the installation destination on Linux. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[norio-nomura]

Not in apple/swift, but we have some tests failing on SourceKitten with sourcekitdInProc in Swift 3.1 for Linux that built by me. jpsim/SourceKitten#354
Those tests failed even by applying a workaround using symlink.

[norio-nomura]

https://github.com/norio-nomura/swift/tree/enable-sourcekit-test
It needs renaming sourcekitdInProc to proper name.

/Users/norio/github/swift-dev/build/buildbot_linux/swift-linux-x86_64/bin/sourcekitd-test: error while loading shared libraries: sourcekitdInProc: cannot open shared object file: No such file or directory

[norio-nomura]

I added norio-nomura@d9a7f49 renaming to libsourcekitdInProc.so.

[norio-nomura]

Opened #8485

[norio-nomura]

Adjusted rpath that assuming sourcekit-inproc's path is /usr/lib/libsourcekitdInProc.so by #8485

[alblue]

@swift-ci please smoke test

[norio-nomura]

@alblue What else is needed to advance this PR?

[norio-nomura]

#8485 has been reverted by #8988. 😞

[felix91gr]

I think now this can be merged... right? Since #9025 completed the missing piece in #8485 ^^

[alblue]

Can we rebase the change against master to check it applies, and then we can kick off tests again? Alex Sent from my iPhone 📱

…

On 28 Apr 2017, at 22:02, Félix Fischer ***@***.***> wrote: I think now this can be merged... right? Since #9025 completed the missing piece in #8485 ^^ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[norio-nomura]

rebased.

[alblue]

@swift-CIA please smoke test

[alblue]

@swift-ci please smoke test

[norio-nomura]

Can we retry test?

[CodaFi]

@swift-ci please clean smoke test Linux platform

[norio-nomura]

Can we retry?

[norio-nomura]

I think that failed test is not related to my changes…
https://ci.swift.org/job/swift-PR-Linux-smoke-test/7184/consoleFull#708282560ee1a197b-acac-4b17-83cf-a53b95139a76

[felix91gr]

I think you can test it, but merging with the latest tag instead of with the latest commit.

…

On Sat, Apr 29, 2017 at 1:26 AM Norio Nomura ***@***.***> wrote: I think that failed test is not related to my changes… https://ci.swift.org/job/swift-PR-Linux-smoke-test/7184/consoleFull#708282560ee1a197b-acac-4b17-83cf-a53b95139a76 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#8189 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALNBJx9N3gvhgDUrxBdvEmFr7AkV8e-6ks5r0rvXgaJpZM4MhsnQ> .

[aciidgh]

@swift-ci please smoke test Linux platform

[norio-nomura]

Yay! 🙌 Thanks! 🙏

[felix91gr]

🎉🎉🎉 Awesome!

…

On Sat, Apr 29, 2017 at 6:02 AM Norio Nomura ***@***.***> wrote: Yay! 🙌 Thanks! 🙏 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#8189 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALNBJxfjX5vNVTSjmz57Mk1Lkjdz7kFcks5r0vyfgaJpZM4MhsnQ> .