Add FreeBSD overlay #79261
Open
Add FreeBSD overlay #79261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-yuji
requested review from
a team,
eeckstein,
rjmccall,
ktoso,
al45tair,
slavapestov,
jckarter,
MaxDesiatov,
etcwilde,
zoecarver,
hyp,
egorzhdan,
beccadax,
ian-twilightcoder and
Xazax-hun
as code owners
finagolfin
reviewed
Feb 10, 2025
| //} | ||
|
|
||
| module SwiftFreeBSD [system] { | ||
| header "SwiftFreeBSD.h" |
There was a problem hiding this comment.
Why lump all the headers into this single header after listing them all above, unable to create a module including all these here directly like the ucrt module?
|
FWIW, having to touch every single import across the codebase is kind of what I was afraid of. It would be good to get some consensus as to what the right way forward is with libc imports before doing this; I'm not sure we're there yet. I don't know. Subscribing to this anyway out of curiosity. |
|
As you well know, there is no plan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a new FreeBSD overlay and change imports accordingly