Update -swift-version to default to 6 for swift-tools-version 6 #7469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
commented
Apr 18, 2024
|
@swift-ci please test |
MaxDesiatov
approved these changes
Apr 18, 2024
|
@swift-ci test |
|
We need to update |
|
@swift-ci please test |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
bnbarham
force-pushed
the
6-when-tools-version-6
branch
2 times, most recently
from
d0a0efc to
f5ee182
Compare
|
@swift-ci test |
MaxDesiatov
added
build system
bnbarham
force-pushed
the
6-when-tools-version-6
branch
from
f5ee182 to
0a4d57a
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
6-when-tools-version-6
branch
from
0a4d57a to
417bfc8
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
6-when-tools-version-6
branch
2 times, most recently
from
458abfd to
92b5601
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
6-when-tools-version-6
branch
from
92b5601 to
29ab4d5
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
6-when-tools-version-6
branch
from
29ab4d5 to
429dc36
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
6-when-tools-version-6
branch
from
47d63c2 to
9f7c5c7
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
6-when-tools-version-6
branch
2 times, most recently
from
be8cb20 to
a0aeb79
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
6-when-tools-version-6
branch
from
a0aeb79 to
608d216
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
6-when-tools-version-6
branch
from
608d216 to
6f4953c
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
6-when-tools-version-6
branch
from
6f4953c to
33bb021
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
6-when-tools-version-6
branch
from
33bb021 to
099871f
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
6-when-tools-version-6
branch
from
099871f to
3c3dab0
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
6-when-tools-version-6
branch
from
3c3dab0 to
e834159
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
This was referenced May 7, 2024
xedin
approved these changes
May 7, 2024
| @@ -34,5 +34,6 @@ let package = Package( | |||
| "MyPlugin2", | |||
| ] | |||
| ), | |||
| ] | |||
| ], | |||
| swiftLanguageVersions: [.v5] | |||
We missed updating this when adding 6.0. The change itself is extremely simple, with the bulk being updates to our tests so they don't fail on old compiler versions (where language version "6" is unknown). Also removes disabling the concurrency and string processing imports from manifest loading, as this was causing the `package` global to not be main actor isolated by default and thus error in Swift 6. They seemed to have been disabled to avoid erroring in SDKs that didn't have them, but that is definitely not an issue any longer.
bnbarham
force-pushed
the
6-when-tools-version-6
branch
from
e834159 to
de3f697
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
@swift-ci please test Linux platform |
shahmishal
pushed a commit
that referenced
this pull request
May 18, 2024
…#7531) **Explanation**: Changes packages to default to swift version 6 when `swift-tools-version` is set `>= 6.0`. Without this change, all packages will be swift version 5 unless otherwise specified via `swiftLanguageVersions`. Packages default to `swift-tools-version: 6.0` with `swift package init`. Users can opt-out via specifying `swiftLanguageVersions: [.v5]`. **Scope**: New packages/those updated to 6.0. **Risk**: Medium. There's inherent risk due to the language mode bump. The change also removes disabling implicit imports for concurrency and string processing in manifest files, which hasn't been widely tested outside of ... **Testing**: New regression tests. Source compatibility suite run. **Original PR**: #7469
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed updating this when adding 6.0. The change itself is extremely
simple, with the bulk being updates to our tests so they don't fail on
old compiler versions (where language version "6" is unknown).
Also removes disabling the concurrency and string processing imports
from manifest loading, as this was causing the
packageglobal to notbe main actor isolated by default and thus error in Swift 6. They seemed
to have been disabled to avoid erroring in SDKs that didn't have them,
but that is definitely not an issue any longer.