Revert "Exclude XCBuildSupport when building with CMake (#7358)"
#7371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added to the `Package.swift` in swiftlang#7258 but skipped in the CMake because swiftlang#7358 excluded XCBuildSupport as a CMake target. But that's reverted here, so we need to add the dependency in.
|
@swift-ci please test |
|
https://ci.swift.org/job/swift-PR-toolchain-macos/1123/ for toolchain test |
Use the new `SwiftCommandState` name rather than `SwiftTool`.
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
MaxDesiatov
approved these changes
Feb 27, 2024
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…7358)" (swiftlang#7371) This reverts commit 5287062, which causes macOS toolchain builds to fail with: ``` main/main.swift:345: Fatal error: SwiftPM was built without XCBuild support ``` Also adds the DriverSupport dependency to XCBuildSupport, which was skipped in swiftlang#7258 because swiftlang#7358 was merged (but we're reverting that).
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…7358)" (swiftlang#7371) This reverts commit 5287062, which causes macOS toolchain builds to fail with: ``` main/main.swift:345: Fatal error: SwiftPM was built without XCBuild support ``` Also adds the DriverSupport dependency to XCBuildSupport, which was skipped in swiftlang#7258 because swiftlang#7358 was merged (but we're reverting that).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5287062, which causes macOS toolchain builds to fail with:
Also adds the DriverSupport dependency to XCBuildSupport, which was skipped in #7258 because #7358 was merged (but we're reverting that).