Install the SourceKit plugin into Windows toolchains #364
Conversation
ahoppen
requested review from
shahmishal,
compnerd and
etcwilde
as code owners
platforms/Windows/ide/ide.wxs
Outdated
| @@ -37,6 +37,14 @@ | |||
| <File Source="$(TOOLCHAIN_ROOT)\usr\lib\sourcekitdInProc.lib" /> | |||
| </Component> | |||
|
|
|||
| <Component Directory="_usr_lib"> | |||
There was a problem hiding this comment.
This seems like the wrong place ... DLLs are placed into the bin directory, lib should have static libraries and import libraries.
There was a problem hiding this comment.
These libraries will be opened by SourceKit using dlopen and are not directly linked to SourceKit. Hence, they don’t ned to go into bin for Windows to pick them up and I thus thought that it makes more sense to put them in lib. Happy to change it, if you prefer to have them in bin.
There was a problem hiding this comment.
I think that they should be in bin. Unless they are completely standalone (including any system library dependencies). The current directory is scanned for any dependencies, and having them elsewhere makes that difficult.
There was a problem hiding this comment.
These libraries are fully standalone and don’t depend on any of the other libraries in bin.
There was a problem hiding this comment.
But that also includes the C/C++ runtimes. They can also be redistributed in the toolchain (and if we run into the cases where we need to, we would fall back to that). In the mean time, note that other "plugin" libraries are loaded from bin on Windows.
There was a problem hiding this comment.
Ah, I see. Moved it to bin
ahoppen
force-pushed
the
install-sourcekit-plugin
branch
from
2ecee64 to
99384ee
Compare
Install the SourceKit plugin, added by swiftlang/sourcekit-lsp#1906 into the Windows toolchains. rdar://142909870
ahoppen
force-pushed
the
install-sourcekit-plugin
branch
from
99384ee to
7ff716c
Compare
|
Please do a cross-repository test with |
|
Triggered a toolchain build: swiftlang/swift#37710 (comment) |
|
Verified that the produced toolchain contains |
Install the SourceKit plugin, added by swiftlang/sourcekit-lsp#1906 into the Windows toolchains.
rdar://142909870