[5.10] Use new SwiftPM flag to remove $ORIGIN from installed sourcekit-lsp ELF executable runpath
#913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ELF executable runpath Also, move installation-only environment variable into get_swiftpm_environment_variables().
|
@swift-ci please test |
bnbarham
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of #894
Explanation: Without this flag,
sourcekit-lsplooks inusr/bin/first for shared libraries, but there are none in that executable directory.Scope: installed executable runpath
Issue: none
Risk: none, there were no shared libraries there
Testing: SwiftPM merged using this flag into trunk and 5.10 last week, no problems with
swift-packageitself so far.Reviewer: @ahoppen