Use the new SwiftPM API to load the build plan #1973
+401
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
force-pushed
the
generated-source-should-work
branch
from
3e7ca95 to
0c4c75c
Compare
|
swiftlang/swift-package-manager#8286 @swift-ci please test |
|
Will need to update this to only build plugins when background indexing is enabled so that we don’t conflict with the regular build directory. |
bnbarham
force-pushed
the
generated-source-should-work
branch
from
0c4c75c to
1d65ff0
Compare
bnbarham
force-pushed
the
generated-source-should-work
branch
from
1d65ff0 to
95e49b5
Compare
|
swiftlang/swift-package-manager#8286 @swift-ci please test |
|
swiftlang/swift-package-manager#8286 @swift-ci please test Windows platform |
bnbarham
force-pushed
the
generated-source-should-work
branch
from
95e49b5 to
54a1e02
Compare
|
swiftlang/swift-package-manager#8286 @swift-ci please test |
|
swiftlang/swift-package-manager#8286 @swift-ci please test Windows platform |
bnbarham
force-pushed
the
generated-source-should-work
branch
2 times, most recently
from
61b34fb to
d762363
Compare
|
swiftlang/swift-package-manager#8286 @swift-ci please test |
|
swiftlang/swift-package-manager#8286 @swift-ci please test Windows platform |
We previously skipped building/running tool plugins here, which meant that the compiler arguments for a target also missed any generated sources. Use the new `BuildDescription.load` API from SwiftPM to address this. Resolves rdar://102242345.
bnbarham
force-pushed
the
generated-source-should-work
branch
from
d762363 to
f142b5c
Compare
|
swiftlang/swift-package-manager#8286 @swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously skipped building/running tool plugins here, which meant that the compiler arguments for a target also missed any generated sources. Use the new
BuildDescription.loadAPI from SwiftPM to address this.Fixes #665
Resolves rdar://102242345.
Resolves rdar://144557689.