Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/20240725] Support Amazon Linux 2 #9136

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

bnbarham
Copy link

@bnbarham bnbarham commented Aug 16, 2024

Couple hacks here:

  1. Drop minimum Python to 3.6 rather than 3.8. It's likely there will be a few failures because of this, but hopefully they don't actually matter for us right now.
  2. Add some extra LLJIT.h includes in. We're seeing failures on Amazon Linux 2 because of only having the forward declaration of llvm::orc::LLJITBuilder. That should be all that's needed, so I'm assuming there's some issue with GCC 7.3 (LLVM supports 7.4+ now).

@bnbarham
Copy link
Author

@swift-ci please test llvm

@bnbarham
Copy link
Author

@swift-ci please test

This was changed back in Februrary, but we still support platforms that
only have Python 3.6 (Amazon Linux 2).
These shouldn't be needed, but see if they fix Amazon Linux 2 anyway.
@bnbarham bnbarham changed the title [rebranch] Drop minimum python support to 3.6 [stable/20240725] Support Amazon Linux 2 Sep 13, 2024
@bnbarham
Copy link
Author

@swift-ci please test llvm

@bnbarham
Copy link
Author

We get to LLDB testing for the toolchain, woo!

@bnbarham bnbarham merged commit 32badcf into swiftlang:stable/20240723 Sep 13, 2024
2 checks passed
@bnbarham bnbarham deleted the try-python-3.6 branch September 13, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant