Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CodingPerfTests executable #57

Merged
merged 3 commits into from
Aug 6, 2020
Merged

Create CodingPerfTests executable #57

merged 3 commits into from
Aug 6, 2020

Conversation

pokryfka
Copy link
Contributor

@pokryfka pokryfka commented Aug 1, 2020

also updated README and CI workflow

@codecov
Copy link

codecov bot commented Aug 1, 2020

Codecov Report

Merging #57 into main will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   90.73%   90.79%   +0.06%     
==========================================
  Files          40       39       -1     
  Lines        3378     3325      -53     
==========================================
- Hits         3065     3019      -46     
+ Misses        313      306       -7     
Impacted Files Coverage Δ
...sts/LearningTests/FoundationJSONEncoderTests.swift 91.83% <0.00%> (-1.15%) ⬇️
...sts/LearningTests/FoundationJSONDecoderTests.swift 93.29% <0.00%> (-0.08%) ⬇️
...arningTests/FoundationJSONSerializationTests.swift

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdbb3d9...715002a. Read the comment docs.

@pokryfka pokryfka changed the title chore: create CodingPerfTests executable Create CodingPerfTests executable Aug 1, 2020
@fabianfett
Copy link
Collaborator

@pokryfka Thank you. This is great! I haven‘t known about swift run before.

@fabianfett fabianfett merged commit 2852986 into swift-extras:main Aug 6, 2020
@pokryfka
Copy link
Contributor Author

pokryfka commented Aug 6, 2020

👍

I was surprised binary was linked without defining executable product :-)
(maybe that was because there is just one file and external libs are dynamically linked?)

.executable(name: "CodingPerfTests", targets: ["CodingPerfTests"]),

swift run -c release is debatable but I think its good in that it does not assume .build structure which, event though unlikely, might change, its an implementation detail after all

@fabianfett fabianfett added this to the v1.0.0 milestone Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants