Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue that led to a crash, if an empty array was decoded #52

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

fabianfett
Copy link
Collaborator

Thanks @calebkleveter for reporting this

@fabianfett fabianfett force-pushed the ff-fix-decode-empty-array branch from 7796e20 to ea6648f Compare July 8, 2020 19:15
@fabianfett fabianfett added this to the v0.4.0 milestone Jul 8, 2020
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #52 into master will increase coverage by 0.05%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   90.68%   90.73%   +0.05%     
==========================================
  Files          40       40              
  Lines        3349     3378      +29     
==========================================
+ Hits         3037     3065      +28     
- Misses        312      313       +1     
Impacted Files Coverage Δ
...PureSwiftJSONTests/Decoding/JSONDecoderTests.swift 93.25% <94.44%> (+0.30%) ⬆️
...ftJSON/Decoding/JSONUnkeyedDecodingContainer.swift 95.23% <100.00%> (+0.04%) ⬆️
...PureSwiftJSONTests/Encoding/JSONEncoderTests.swift 94.25% <100.00%> (+0.50%) ⬆️
...ux/debug/testlist.derived/PureSwiftJSONTests.swift 100.00% <0.00%> (ø)
...kageTestsTestlist.derived/PureSwiftJSONTests.swift 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6497c0...ea6648f. Read the comment docs.

@fabianfett fabianfett merged commit 5dc8ec1 into master Jul 8, 2020
@fabianfett fabianfett deleted the ff-fix-decode-empty-array branch July 8, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant