Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding fixes. #25

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Encoding fixes. #25

merged 1 commit into from
Mar 20, 2020

Conversation

fabianfett
Copy link
Collaborator

Thanks so much @adam-fowler.

This shall fix #21 and #19.

@fabianfett fabianfett added this to the v0.2.0 milestone Mar 20, 2020
@codecov-io
Copy link

codecov-io commented Mar 20, 2020

Codecov Report

Merging #25 into master will increase coverage by 0.83%.
The diff coverage is 95.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   87.97%   88.80%   +0.83%     
==========================================
  Files          32       34       +2     
  Lines        2918     3074     +156     
==========================================
+ Hits         2567     2730     +163     
+ Misses        351      344       -7     
Impacted Files Coverage Δ
...s/Encoding/JSONUnkeyedEncodingContainerTests.swift 94.28% <94.28%> (ø)
...ts/JSONCodingTests/Encoding/JSONEncoderTests.swift 87.69% <95.00%> (+3.24%) ⬆️
...sts/Encoding/JSONKeyedEncodingContainerTests.swift 95.12% <95.12%> (ø)
...ces/PureSwiftJSONCoding/Encoding/JSONEncoder.swift 91.30% <95.91%> (+6.68%) ⬆️
...ONCoding/Encoding/JSONKeyedEncodingContainer.swift 55.00% <100.00%> (+19.00%) ⬆️
...Coding/Encoding/JSONUnkeyedEncodingContainer.swift 46.55% <100.00%> (+25.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9071a99...69e3d42. Read the comment docs.

@fabianfett fabianfett marked this pull request as ready for review March 20, 2020 12:34
@fabianfett fabianfett force-pushed the encoding-fixes branch 2 times, most recently from 81cf45b to a77e39e Compare March 20, 2020 14:09
@fabianfett fabianfett merged commit 92f2f45 into master Mar 20, 2020
@fabianfett fabianfett deleted the encoding-fixes branch March 20, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSONEncoder.codingPath stack is not updated
2 participants