Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow encode<T: Encodable>(_ value: T) in JSONSingleValueEncodingContainer #24

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

fabianfett
Copy link
Collaborator

fixes #19

@codecov-io
Copy link

codecov-io commented Mar 19, 2020

Codecov Report

Merging #24 into master will increase coverage by 0.08%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   87.87%   87.95%   +0.08%     
==========================================
  Files          31       32       +1     
  Lines        2894     2915      +21     
==========================================
+ Hits         2543     2564      +21     
  Misses        351      351              
Impacted Files Coverage Δ
...ng/Encoding/JSONSingleValueEncodingContainer.swift 50.00% <87.50%> (+11.11%) ⬆️
...coding/JSONSingleValueEncodingContainerTests.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a249d...d21c160. Read the comment docs.

@fabianfett fabianfett force-pushed the encode-in-singlevaluecontainer branch from d21c160 to ca81eae Compare March 19, 2020 17:28
@adam-fowler
Copy link

Looks good

@fabianfett fabianfett merged commit 10debb7 into master Mar 19, 2020
@fabianfett fabianfett deleted the encode-in-singlevaluecontainer branch March 19, 2020 18:04
@fabianfett fabianfett added this to the v0.2.0 milestone Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSONEncoder hasn't implemented nestedContainer/nestedUnkeyedContainer
3 participants