Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test environment: reorganized files, split folders, ... #30

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

k00ni
Copy link
Member

@k00ni k00ni commented Jun 29, 2023

Overview

I reorganized our test related files in a way to have a better separation of concerns. For instance, mock files were located next to test files. There are still things to do, but this PR is a good step in the right direction in my opinion. I hope the new structure makes it more clear if someone wants to fix a bug or wanna find certain test cases.

The new test-related folder structure looks roughly like this:

  • root folder
    • test (new) - contains test related (helper) files, fixtures, ...
      • MockClass - contains mock classes
    • tests - contains only test-classes
      • ...
      • ParserTest/RDFa (new) - contains RDFa related test class as well as fixtures

Highlights

highlights:

- separate tests from helper classes, fixtures etc.
- separate RDFa tests from parser tests (put it together with
  fixtures, so all RDFa related test files are together)
- separated mock classes from test classes
- introduced ROOT_PATH constant to avoid __DIR__ usages all
  over the place
@k00ni k00ni self-assigned this Jun 29, 2023
@k00ni k00ni added enhancement New feature or request tests labels Jun 29, 2023
@k00ni
Copy link
Member Author

k00ni commented Jun 29, 2023

I would like to hear your opinion on the general direction of these changes, if you can spare the time.

CC @zozlak @claudiu-cristea @idimopoulos

@k00ni k00ni changed the title Tests environment: reorganized files, split folders, ... Test environment: reorganized files, split folders, ... Jun 29, 2023
@k00ni k00ni merged commit 15062c3 into master Jul 4, 2023
@k00ni k00ni deleted the feature/reorganized-tests branch September 14, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant