-
-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add solutions for exercises 2 and 3 in 09-conflicts #388
Conversation
This provides solutions to two exercises on conflicts: - resolving conflicts in image files, and - a Parson's problem on avoiding conflicts This does not provide a solution to the first conflict exercise, as it would be very similar to the lesson itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me!
> > $ git pull origin master | ||
> > ~~~ | ||
> > {: .bash} | ||
> > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe some transition here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
I'm loath to introduce the idea of committing or dealing with conflicts to binary files. I think it would be confusing to new users who are just being introduced to the concept of diffing on text files. |
This is the solution to an exercise that was already in the episode, so it's already introduced. I suppose you could remove the particular exercise, but I suspect that it's something people will ask. Is there a risk of confusing people if it's buried under an exercise? |
Thanks @tgamblin. I agree with @daisieh that talking about conflicts for binary files maybe a bit too much for a typical learner. However, your text is really well-written and very easy to follow. Instructors are supposed to choose which exercises are done during the workshop, so I think we should merge your PR and let to the instructor's jugedment whether is appropiate for their audience or not. I also think that this may cover the case when people put a previous project under git, committing in the process a binary file (say some data on a spreadsheet). The spreadsheet changes, they get a conflict which they cannot fix by editing the file, they cannot pull/push anymore and they quit using Git. I have one minor request though. Could you think in an easy way of creating the jgp (or whatever binary) files? I'm thinking that in a workshop people would not have handy jpgs to share, or they will be too big, or whatever. It would be ideal if there was something using only command line stuff and available in all OSes. Or maybe just taking a screenshot of the learner's computer would be enough :-) Any ideas @katyhuff ? |
This could be a solution for generating a small, random file with no personal stuff on it:
but uses |
Would it be sufficient to check in the jpg's as part of this exercise, and just use |
Alternately, if you really want random data, you can do this without having to use
|
I think that's perfect! All these are commands that people is familiar with from the shell lesson. Could you just add a short sentence with that when you first mention the |
@iglpdc: done! |
Very nice! Thanks a lot @tgamblin! |
Thanks everyone! |
Add solutions for exercises 2 and 3 in 09-conflicts
This provides solutions to two exercises on conflicts:
This does not provide a solution to the first conflict exercise, as it
would be very similar to the lesson itself.