-
-
Notifications
You must be signed in to change notification settings - Fork 381
Short introduction to the data.table library in R #204
Conversation
Thanks @naupaka and @sckott, I took a quick look and the overall format looks good. @jdblischak, @karthik, do either of you want to mentor the review on this? Note: There is still an open discussion on whether the |
I've dropped a few comments into the code above. Some general thoughts: Overall the material is great for a 2-3 minutes discussion. But I see a few issues.
My recommendation: This is ok to merge as a standalone lesson but I don't see much use for it in the immediate term. It could be brought up in case some students bring up speed or "big" data issues. So @ahmadia I'll leave it up to you to merge after you hear back from @jdblischak |
Thanks for your contribution! Here are my thoughts:
|
|
||
## Combine data.frames | ||
|
||
`data.table` can do more than just read in files though. Another often-completed task is combining two data.frames. Let compare the base R approach to the `data.table` version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: "often-completed" -> "common"
typo: "Let" -> "Let's"
GitHub is actually supposed to be sof |
On Tue, Dec 10, 2013 at 03:29:15PM -0800, Ethan White wrote:
…t wrapping? I thought so too, but maybe .Rmd doesn't count as |
Oops, yes, thanks. It works on the .Rmd on my phone, but not in either Firefox or Chrome on my laptop. |
Thanks all for the helpful comments! I will get to the other suggested changes in the next couple days. |
@@ -0,0 +1,91 @@ | |||
# Introduction to data.table | |||
|
|||
What is the `data.table` library for and why would you want to use it? Doesn't base R come with data frames build in already? Turns out that there are some things that can be done MUCH faster and more easily with data.table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a package, not a library. The latter is a collection of the former.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mybad, thanks for catching that. Will be fixed in the next commit.
I have a PR in to Linguist that would fix this for Rmd files (github-linguist/linguist#831). However there is a test currently failing on Ruby 1.8.7 that I don't know enough to debug. If someone with more Ruby experience (@emhart ?) has a chance to take a look fixing this should increase the chances that this gets implemented quickly. |
@naupaka - Is this ready for review again? |
Not yet, Scott and I still have stuff to fix. Been traveling. |
No problem, just making sure you weren't silently waiting on me :) |
@ethanwhite I checked this out, but I see that they merged the request and that your fork was building fine. Did you resolve the problem? |
@emhart yes, resolved. That discussion was just referenced here and should continue on the original thread if there is anything further. |
Is this one ready to merge? |
I'll take a look and get things fixed, hopefully today. I'm partnering with @naupaka by the wway :) |
Okay all, I've fixed up the |
Let me take a quick look in the next few hours and I'll let you know if I have anything else to add. Thanks!
|
Short introduction to the data.table library in R
Scott and I put together an Rmd file with code and descriptions of several useful features of the data.table library to be used as a short ~3 minute lesson.