Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/minifier): Cache var_or_default calls #9909

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 21, 2025

Description:

This is a simple fix to ensure that we hash the Id only once.

@kdy1 kdy1 added this to the Planned milestone Jan 21, 2025
@kdy1 kdy1 requested a review from a team as a code owner January 21, 2025 10:43
Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: 56e39e9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 21, 2025
@kdy1 kdy1 requested a review from a team as a code owner January 21, 2025 10:43
@kdy1 kdy1 enabled auto-merge (squash) January 21, 2025 10:44
@kdy1 kdy1 disabled auto-merge January 21, 2025 10:48
@kdy1 kdy1 merged commit 4a3be8d into swc-project:main Jan 21, 2025
165 checks passed
@kdy1 kdy1 deleted the min-2 branch January 21, 2025 10:48
kdy1 added a commit that referenced this pull request Jan 21, 2025
**Description:**

Previous PR may decrease the performance if the result of `collect_infects_to` is empty.

**Related issue:**

 - Inverts #9909
@kdy1 kdy1 modified the milestones: Planned, v1.10.9 Jan 21, 2025
Copy link

codspeed-hq bot commented Jan 21, 2025

CodSpeed Performance Report

Merging #9909 will not alter performance

Comparing kdy1:min-2 (56e39e9) with main (ce22557)

Summary

✅ 196 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant