Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(es/base): Disable flaky benchmark #9221

Merged
merged 2 commits into from
Jul 12, 2024
Merged

test(es/base): Disable flaky benchmark #9221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8ae0a9
disable flaky bench
kdy1 Jul 12, 2024
6d1bb12
Merge branch 'main' into flaky-ci
swc-bot Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 24 additions & 23 deletions crates/swc/benches/typescript.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ use swc_common::{
use swc_compiler_base::PrintArgs;
use swc_ecma_ast::{EsVersion, Program};
use swc_ecma_parser::Syntax;
use swc_ecma_transforms::{fixer, hygiene, resolver, typescript};
use swc_ecma_transforms::{fixer, resolver, typescript};
use swc_ecma_visit::FoldWith;

static SOURCE: &str = include_str!("assets/Observable.ts");
Expand Down Expand Up @@ -58,10 +58,10 @@ fn as_es(c: &swc::Compiler) -> Program {

fn base_tr_group(c: &mut Criterion) {
c.bench_function("es/full/base/fixer", base_tr_fixer);
c.bench_function(
"es/full/base/resolver_and_hygiene",
base_tr_resolver_and_hygiene,
);
// c.bench_function(
// "es/full/base/resolver_and_hygiene",
// base_tr_resolver_and_hygiene,
// );
}

fn base_tr_fixer(b: &mut Bencher) {
Expand All @@ -80,24 +80,25 @@ fn base_tr_fixer(b: &mut Bencher) {
});
}

fn base_tr_resolver_and_hygiene(b: &mut Bencher) {
let c = mk();
GLOBALS.set(&Default::default(), || {
let module = as_es(&c);

b.iter(|| {
GLOBALS.set(&Default::default(), || {
let handler = Handler::with_emitter_writer(Box::new(stderr()), Some(c.cm.clone()));
black_box(c.run_transform(&handler, true, || {
module
.clone()
.fold_with(&mut resolver(Mark::new(), Mark::new(), false))
.fold_with(&mut hygiene())
}))
})
});
})
}
// fn base_tr_resolver_and_hygiene(b: &mut Bencher) {
// let c = mk();
// GLOBALS.set(&Default::default(), || {
// let module = as_es(&c);

// b.iter(|| {
// GLOBALS.set(&Default::default(), || {
// let handler =
// Handler::with_emitter_writer(Box::new(stderr()), Some(c.cm.clone()));
// black_box(c.run_transform(&handler, true, || {
// module
// .clone()
// .fold_with(&mut resolver(Mark::new(), Mark::new(),
// false)) .fold_with(&mut hygiene())
// }))
// })
// });
// })
// }

/// This benchmark exists to know exact execution time of each pass.

Expand Down
Loading