Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/decorators): Support negative numbers #10114

Merged
merged 4 commits into from
Feb 27, 2025
Merged

fix(es/decorators): Support negative numbers #10114

merged 4 commits into from
Feb 27, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 27, 2025

Description:

A negative number is not a numeric literal so we need to handle unary expressions with op = "-".

Related issue:

@kdy1 kdy1 added this to the Planned milestone Feb 27, 2025
@kdy1 kdy1 self-assigned this Feb 27, 2025
@kdy1 kdy1 requested a review from a team as a code owner February 27, 2025 06:10
Copy link

changeset-bot bot commented Feb 27, 2025

🦋 Changeset detected

Latest commit: 8866f24

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 requested a review from a team as a code owner February 27, 2025 06:11
@kdy1 kdy1 enabled auto-merge (squash) February 27, 2025 06:11
@kdy1 kdy1 disabled auto-merge February 27, 2025 06:23
@kdy1 kdy1 merged commit 5044580 into main Feb 27, 2025
169 checks passed
@kdy1 kdy1 deleted the issue-10094 branch February 27, 2025 06:23
@kdy1 kdy1 modified the milestones: Planned, v1.11.2 Feb 27, 2025
Copy link

codspeed-hq bot commented Feb 27, 2025

CodSpeed Performance Report

Merging #10114 will degrade performances by 4.6%

Comparing issue-10094 (8866f24) with main (8c5f7ef)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 189 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/lodash 195.4 ms 187.1 ms +4.41%
es/minifier/libs/jquery 132.1 ms 138.5 ms -4.6%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Negative number in enum will be outputed as Object in metatype
1 participant