Skip to content

Commit

Permalink
fix(es/compat): Fix marker for inlined helpers (#9776)
Browse files Browse the repository at this point in the history
**Related issue:**

 - Closes #9673
  • Loading branch information
kdy1 authored Dec 2, 2024
1 parent 70fcbc4 commit f54ec2c
Show file tree
Hide file tree
Showing 5 changed files with 52 additions and 1 deletion.
6 changes: 6 additions & 0 deletions .changeset/modern-carpets-attend.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
swc_core: patch
swc_ecma_transforms_base: patch
---

Add a test
20 changes: 20 additions & 0 deletions crates/swc/tests/fixture/issues-9xxx/9673/input/.swcrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"jsc": {
"parser": {
"syntax": "ecmascript",
"jsx": false,
"explicitResourceManagement": true
},
"target": "es2022",
"loose": false,
"minify": {
"compress": false,
"mangle": false
}
},
"module": {
"type": "commonjs"
},
"minify": false,
"isModule": true
}
5 changes: 5 additions & 0 deletions crates/swc/tests/fixture/issues-9xxx/9673/input/1.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
using x = {
[Symbol.dispose]() {
console.log("disposed")
}
};
20 changes: 20 additions & 0 deletions crates/swc/tests/fixture/issues-9xxx/9673/output/1.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
var _ts_add_disposable_resource = require("@swc/helpers/_/_ts_add_disposable_resource");
var _ts_dispose_resources = require("@swc/helpers/_/_ts_dispose_resources");
const env = {
stack: [],
error: void 0,
hasError: false
};
try {
const x = _ts_add_disposable_resource._(env, {
[Symbol.dispose] () {
console.log("disposed");
}
}, false);
;
} catch (e) {
env.error = e;
env.hasError = true;
} finally{
_ts_dispose_resources._(env);
}
2 changes: 1 addition & 1 deletion crates/swc_ecma_transforms_base/src/helpers/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ impl VisitMut for Marker {
return;
}

if !i.sym.starts_with("__") {
if !(i.sym.starts_with("__") && i.sym.starts_with("_ts_")) {
self.decls.insert(i.sym.clone(), self.decl_ctxt);
}
}
Expand Down

0 comments on commit f54ec2c

Please sign in to comment.