Inject connections into constructor instead of using a method #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It also exposes the clients through the container 👍 |
| * {@inheritDoc} | ||
| */ | ||
| public function addConnection($name, array $connection) | ||
| public function __construct(array $connections = []) |
| } | ||
| $container->setParameter('swarrot.connections', $connections); |
There was a problem hiding this comment.
IMO, you should replace the argument instead of adding a parameter for that
There was a problem hiding this comment.
I closed this PR without merging it.
In fact, I needed this connections list to be able to reuse them in another bundle that's why I wished I had this parameter. :)
PR #67 solved my problem as it already expose a parameter containing the connection list.
There was a problem hiding this comment.
well, removing the mutator from the interface still makes sense to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason to use a
addConnectioninstead of pass them directly to the constructor.