Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor word search using structure recognition #1792

Merged
merged 2 commits into from
Mar 15, 2024
Merged

refactor word search using structure recognition #1792

merged 2 commits into from
Mar 15, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Mar 14, 2024 •
edited
Loading

Makes use of rotation-aware structure recognition (#1678) to simplify goal checking for word search (#999).

Screenshot from 2024-03-13 18-48-53

Benchmarks

Using the following command (GHC 9.6.4):

scripts/run-tests.sh --test-arguments '--pattern "word-search"'
Before After
0.98s 0.82s

@kostmo kostmo added Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. Z-Performance This issue concerns memory or time efficiency of the Swarm game. labels Mar 14, 2024
@kostmo kostmo requested a review from byorgey March 14, 2024 01:49
@kostmo kostmo marked this pull request as ready for review March 14, 2024 01:49
@kostmo kostmo changed the title refactor using structure recognition refactor word search using structure recognition Mar 14, 2024
byorgey
byorgey approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Mar 15, 2024
@mergify mergify bot merged commit 55271c0 into main Mar 15, 2024
9 checks passed
@mergify mergify bot deleted the refactor/word-search-using-structures branch March 15, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request. Z-Performance This issue concerns memory or time efficiency of the Swarm game. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey