Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: required properties #7206

Merged
merged 9 commits into from
Apr 29, 2021
Merged

Conversation

mathis-m
Copy link
Contributor

schema required properties should not be treated like required: true.
this lead to objects that requires properies beeing treated as required itself

Description

Motivation and Context

Fixes #7205
Fixes #7086

How Has This Been Tested?

browser

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

mathis-m and others added 2 commits April 23, 2021 02:47
schema required properties should not be treated like required: true.
this lead to objects that requires properies beeing treated as required itself

Signed-off-by: mathis-m <[email protected]>
@tim-lai
Copy link
Contributor

tim-lai commented Apr 27, 2021

@mathis-m Thanks for the PR! Can you add Cypress tests, one of each definition from the linked issues?

dependabot bot and others added 7 commits April 28, 2021 05:16
schema required properties should not be treated like required: true.
this lead to objects that requires properies beeing treated as required itself

Signed-off-by: mathis-m <[email protected]>
@tim-lai tim-lai merged commit 53829f1 into swagger-api:master Apr 29, 2021
@tim-lai
Copy link
Contributor

tim-lai commented Apr 29, 2021

@mathis-m PR merged! Thanks for the fix. Fyi, I added a test that covered both cited issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants