Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change extension for CSV data #7141

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Change extension for CSV data #7141

merged 2 commits into from
Mar 30, 2021

Conversation

axel584
Copy link
Contributor

@axel584 axel584 commented Mar 30, 2021

Description

When I download data in text / csv format, I would like the extension offered to be ".csv" (instead of the ".txt" currently offered)

Motivation and Context

Currently, the extension of the file is ".txt" and users seem to have difficulty opening the generated file.

How Has This Been Tested?

I try the fix on my local swagger.

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

I am not sure if the current name used at the time of data download is covered by a unit test.
The current code manages several formats (image, pdf, xml, html ...). If this part of the code is covered by unit tests, they should indeed be added.

@tim-lai tim-lai merged commit 75865f3 into swagger-api:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants