Support OAuth2 PKCE when using the OIDC authorization_code flow #6914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous checks only supported the OAuth2 authorizationCode flow and missed the equivalent OIDC flow.
brandonros
reviewed
Feb 8, 2021
| @@ -77,7 +77,7 @@ export default function authorize ( { auth, authActions, errActions, configs, au | |||
| query.push("realm=" + encodeURIComponent(authConfigs.realm)) | |||
| } | |||
|
|
|||
| if ((flow === "authorizationCode" || flow === "accessCode") && authConfigs.usePkceWithAuthorizationCodeGrant) { | |||
| if ((flow === "authorizationCode" || flow === "authorization_code" || flow === "accessCode") && authConfigs.usePkceWithAuthorizationCodeGrant) { | |||
There was a problem hiding this comment.
i wonder if you should do flow === 'access_code' too?
brandonros
approved these changes
Feb 8, 2021
|
@ChadKillingsworth PR merged! Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Security schemes using OIDC did not support PKCE even when enabled in the config. The check was only looking for the manually defined "authorizationCode" flow from an OAuth2 scheme and not the "authorization_code" flow from an OIDC grant.
Motivation and Context
My provider requires PKCE to be used and the integration is currently failing. Adding this check properly supports PKCE.
How Has This Been Tested?
A unit test was added specifically for this flow (copied from the authorizationCode flow). The changes were manually applied to my project to ensure that PKCE was indeed working.
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests