-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Advanced Filter (Regex Matching, Case Matching, Full Words Matching, Tag/Route) #6744
Closed
mathis-m
wants to merge
7
commits into
swagger-api:master
from
mathis-m:feature/filter-configuration
Closed
Feature: Advanced Filter (Regex Matching, Case Matching, Full Words Matching, Tag/Route) #6744
mathis-m
wants to merge
7
commits into
swagger-api:master
from
mathis-m:feature/filter-configuration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
672a025
to
6458623
Compare
introduce filterConfig to activate case-, words-, regex-matching
input is now span contenteditable
6458623
to
575bc62
Compare
added select to switch between tag and route search
Hi @mathis-m, this PR and demo looks very promising. A couple of thoughts:
Finally, expect that this will need a UX/UI review once we get through the functionality implementation. |
Hi @tim-lai, thanks for your Feedback and I completely agree on all your points. |
1 task
closing in favor of #6851 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to reflect common filtering, like we all know from IDE's, there is the need for new filter configuration options.
It need to store the 3 Flags: regex-, case-, full words-mode and the search location (tag or route/path).
In order to reflect the old behavior defaults are like the following:
Have a look at the preview.
Open for more filter features, let's discuss this in #6753.
Motivation and Context
Reflect common filtering, like we all know from IDE's.
Fixes #6648
How Has This Been Tested?
Fixed suts of tests using the filter logic to provide the
currentFilterConfig
.Wrote tests for new filter algorithm
src/core/plugins/filter/opsFilter.js
.Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests