Upgraded highlight version to 9.1, removed highlight when sample is t… #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good. Can you make the highlight threshold use the |
|
@bodnia can you please rebase? |
For `Example Value`.
An accent was forgotten
…ht when length more than highlightSizeThreshold
|
@fehguy I rebased and also could you please review the commit bodnia@ed7c726 Thanks! |
Jonahss
pushed a commit
to eaze/swagger-ui
that referenced
this pull request
Aug 12, 2016
…ble highlight when length more than highlightSizeThreshold
vincent-zurczak
pushed a commit
to roboconf/swagger-ui
that referenced
this pull request
Aug 19, 2016
…ble highlight when length more than highlightSizeThreshold
JuanSW18
pushed a commit
to Digital-Paw/digital-paw-swagger-ui
that referenced
this pull request
Aug 23, 2024
…ble highlight when length more than highlightSizeThreshold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fehguy upgraded highlight version to 9.1, which looks a little bit faster, but still causes the blocking screen. It might be placed into workers but browsers restrict running web workers with local files (Chrome allows only when running it with --allow-file-access-from-files flag. So it's not an option when running only index.html without server. So where is added class nohighlight when example length is more than 5000 and highlighter isn't run for this piece of code.