Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swagger-ui-react: regression in rendering #9846

Closed
char0n opened this issue Apr 19, 2024 · 2 comments · May be fixed by codingfragments/tvh-guide#134
Closed

swagger-ui-react: regression in rendering #9846

char0n opened this issue Apr 19, 2024 · 2 comments · May be fixed by codingfragments/tvh-guide#134
Assignees
@char0n
Labels
type: bug version: 5.x

Comments

@char0n
Copy link
Member

char0n commented Apr 19, 2024

Regression was caused by #9818

The systemOptions contains dom_id=#swagger-ui as a default. Which means that when the swagger-ui-react is mounted, SwaggerUI still tries to render itself on top of #swagger-ui dom Node.

Remediation: we have to make sure, we're overriding dom_id and domNode explicitly from swagger-ui-react.
@char0n char0n self-assigned this Apr 19, 2024
char0n added a commit that referenced this issue Apr 19, 2024
@char0n
fix(swagger-ui-react): avoid triggering implicit system rendering
abd5557 
Refs #9846
@char0n char0n mentioned this issue Apr 19, 2024
Merged
char0n added a commit that referenced this issue Apr 19, 2024
@char0n
fix(swagger-ui-react): avoid triggering implicit system rendering (#9847
3a671c6 
)

Refs #9846
@char0n
Copy link
Member Author

char0n commented Apr 19, 2024

Addressed in #9847

@char0n char0n closed this as completed Apr 19, 2024
@char0n
Copy link
Member Author

char0n commented Apr 19, 2024

Released as https://github.com/swagger-api/swagger-ui/releases/tag/v5.16.2

@leika leika mentioned this issue May 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
type: bug version: 5.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade swagger-ui from 5.11.0 to 5.17.7 codingfragments/tvh-guide
1 participant
@char0n