Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circular Reference generate errors #2889

Closed
matthieugeerebaert opened this issue Apr 10, 2017 · 8 comments
Closed

Circular Reference generate errors #2889

matthieugeerebaert opened this issue Apr 10, 2017 · 8 comments
Assignees
@shockey
Labels
locked-by: lock-bot P1 type: bug version: 3.x

Comments

@matthieugeerebaert
Copy link

matthieugeerebaert commented Apr 10, 2017 •
edited
Loading

On master

Circular reference generate errors.

Like "Node" contains a list of nodes for instance

Errors

Resolver error
too much recursion
Resolver error
too much recursion

Parameters view is also broken

Maybe relative to
Very slow loading times #1919
@webron
Copy link
Contributor

webron commented Apr 10, 2017

Can you share a spec that reproduces it? We've tested circular reference support.

@matthieugeerebaert
Copy link
Author

Here it is

circular.swagger.json.zip

@matthieugeerebaert
Copy link
Author

3.0.3 OK
3.0.5 and master KO

@webron
Copy link
Contributor

webron commented Apr 10, 2017

Interesting. I see a different behavior if the file is embedded vs hosted. No major issues with the embedded version, but once hosted... 💥.

@shockey
Copy link
Contributor

shockey commented Apr 25, 2017

Looks like it was introduced into the static build here: dd8fb58

@shockey
Copy link
Contributor

shockey commented Apr 25, 2017

I see a different behavior if the file is embedded vs hosted.

@webron, thanks for the hint. You just saved me a couple additional hours of debugging 😄

The problem has been isolated to swagger-js, writing regression tests and looking for a fix now.

@shockey
Copy link
Contributor

shockey commented Apr 26, 2017

Problem introduced here: swagger-api/swagger-js@4e2dff33e75744e9

@shockey shockey mentioned this issue Apr 26, 2017
Closed
@mkleina mkleina mentioned this issue Apr 27, 2017
Merged
@buunguyen buunguyen mentioned this issue Apr 27, 2017
Merged
@shockey
Copy link
Contributor

shockey commented Apr 28, 2017

Hi everyone - we just merged the PR that fixes this in swagger-js, and you can expect the fix to be in our Friday release tomorrow evening 😄

shockey added a commit to shockey/swagger-ui that referenced this issue Apr 29, 2017
@shockey
v3.0.8 (fixes swagger-api#2923 swagger-api#2889)
c08f3c2
@shockey shockey closed this as completed Apr 29, 2017
@sgyang sgyang mentioned this issue May 2, 2017
Closed
dwasyluk added a commit to syscoin/swagger-ui that referenced this issue May 5, 2017
@dwasyluk
Merge branch 'swaggerui-master' into syscoin:swagger-ui master
b13459c 
* swaggerui-master: (132 commits)
  enable configs plugin by default
  Rebuild dist
  fix swagger-api#2841
  Make the checkbox id more unique.
  Rebuild dist
  Fix swagger-api#3016
  removed semicolon
  preventDefault the form
  v3.0.8 (fixes swagger-api#2923 swagger-api#2889)
  Rebuild dist
  Increment swagger-client version
  Attach information to version object
  Fix swagger-api#3003
  updated searchbar sizing
  build
  remove object-assign dep ( which was missing from package.json )
  fix swagger-api#2870
  Fix typo in container classname
  fix eslint errors
  swagger-api#2844 fix accessCode flow
  ...

# Conflicts:
#	dist/swagger-ui-bundle.js
#	dist/swagger-ui-bundle.js.map
#	dist/swagger-ui-standalone-preset.js
#	dist/swagger-ui-standalone-preset.js.map
#	dist/swagger-ui.css
#	dist/swagger-ui.js
#	dist/swagger-ui.js.map
#	src/plugins/topbar/topbar.jsx
@lock lock bot locked and limited conversation to collaborators Jul 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shockey shockey

Labels
locked-by: lock-bot P1 type: bug version: 3.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@webron @shockey @matthieugeerebaert