Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix schemas parse inconsistencies #1541

Merged

Conversation

GabrielCastro
Copy link

@GabrielCastro GabrielCastro commented Mar 26, 2021

schemas an of inline responses are parsed different from ones in definitions.

This manifests it's self as a bug in the generator: OpenAPITools/openapi-generator#9086 where additionalProperties behaves differently if it's in a response in-line or in definitions.

GabrielCastro added a commit to GabrielCastro/swagger-parser that referenced this pull request Mar 26, 2021
GabrielCastro added a commit to GabrielCastro/swagger-parser that referenced this pull request Mar 26, 2021
@GabrielCastro GabrielCastro force-pushed the fix/schema-parsing-inconsistencies branch from 989043a to 0484fc9 Compare March 26, 2021 02:06
@GabrielCastro GabrielCastro force-pushed the fix/schema-parsing-inconsistencies branch from 0484fc9 to f8ade46 Compare March 26, 2021 02:21
@GabrielCastro GabrielCastro marked this pull request as ready for review March 26, 2021 02:27
@GabrielCastro
Copy link
Author

@frantuma
@gracekarina

@amjmhs
Copy link

amjmhs commented Apr 15, 2021

isn't this the same issue as #1552 and according PR #1554 ?

@GabrielCastro
Copy link
Author

isn't this the same issue as #1552 and according PR #1554 ?

Yes, it is

@GabrielCastro
Copy link
Author

It would be great to have either fix merged
cc: @frantuma @gracekarina

@gracekarina gracekarina merged commit cbb7b77 into swagger-api:v1 Apr 20, 2021
@gracekarina
Copy link
Contributor

thanks for the PR and adding the test! @GabrielCastro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants