Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getter and Setter for hideGenerationTimestamp #7998

Merged
merged 4 commits into from
Apr 11, 2018

Conversation

jmini
Copy link
Contributor

@jmini jmini commented Apr 10, 2018

Work in progress for #7997.

@jmini
Copy link
Contributor Author

jmini commented Apr 10, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. => this is not necessary because no generated code is affected. Unit tests were created to ensure no regression.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. => I am not sure who is concerned by this technical change.

Description of the PR

See: #7997


I do not think that I am responsible for Build FAILED in CircleCI. The main commit eb3abda1242306ebf3f6226fe9963f65ef5c5785 has 4 successful checks.

@wing328
Copy link
Contributor

wing328 commented Apr 11, 2018

@jmini thanks for the PR, which looks good to me.

@wing328 wing328 merged commit d0e2d76 into swagger-api:master Apr 11, 2018
@wing328 wing328 added this to the v2.4.0 milestone Apr 11, 2018
@jmini
Copy link
Contributor Author

jmini commented Apr 12, 2018

Thank you for the merge of this PR. When I wanted to use it in my project, I have noticed, that the setter und getter should also be available on the Interface: I have opened #8009 for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants