-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[csharp] Update JsonSubTypes to 1.1.3 and use nuget dependency #6969
[csharp] Update JsonSubTypes to 1.1.3 and use nuget dependency #6969
Conversation
- samples\client\petstore\csharp - samples\client\petstore\csharp-dotnet2 then ran : bin\windows\csharp-petstore-all.bat
… is compatible with net40) - allign all version of Newtonsoft.Json to 10.0.3
Isn't this nuget artifact incompatible with .net 3.5? I haven't pulled this to try, as I've been busy. .NET 3.5 isn't documented on the Nuget page. Also, this nuget assembly has to be added to compile.mustache. |
@jimschubert The nuget is not compatible with .net 3.5. Is .net 3.5 supported by swagger-codegen? (I don't see where) |
Yes. Please run the CLI with The default conditions in our templates are .NET 3.5 compatible. Options are passed to templates for additional features such as async support. We also pass additional properties such as |
@jimschubert the nuget artifact is compatible with .NET 3.5 but on release I'll make another PR in order to handle .NET 3.5 |
Cool. I didn't see that when I looked. Are there API differences in usage between these versions? If not, it should just be a simple template switch in the project files, build script, and package file. |
@jimschubert There is no API differences in usage |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.3.0.0
branch for changes related to OpenAPI spec 3.0. Default:master
.Description of the PR
cc: @mandrean, @jimschubert