Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp] Update JsonSubTypes to 1.1.3 and use nuget dependency #6969

Merged
merged 7 commits into from
Nov 21, 2017
Merged

[csharp] Update JsonSubTypes to 1.1.3 and use nuget dependency #6969

merged 7 commits into from
Nov 21, 2017

Conversation

manuc66
Copy link
Contributor

@manuc66 manuc66 commented Nov 15, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • update JsonSubTypes to 1.1.3 by using nuget dependency (the package is compatible with net40)
  • align all version of Newtonsoft.Json to 10.0.3
  • update windows scripts

cc: @mandrean, @jimschubert

@manuc66 manuc66 changed the title Feature/jsonsubtype nuget [csharp] Update JsonSubTypes to 1.1.3 and use nuget dependency Nov 16, 2017
@wing328 wing328 added this to the v2.3.0 milestone Nov 17, 2017
@wing328 wing328 merged commit b06ccec into swagger-api:master Nov 21, 2017
@jimschubert
Copy link
Contributor

Isn't this nuget artifact incompatible with .net 3.5? I haven't pulled this to try, as I've been busy. .NET 3.5 isn't documented on the Nuget page.

Also, this nuget assembly has to be added to compile.mustache.

@manuc66
Copy link
Contributor Author

manuc66 commented Nov 21, 2017

@jimschubert The nuget is not compatible with .net 3.5.

Is .net 3.5 supported by swagger-codegen? (I don't see where)

@jimschubert
Copy link
Contributor

Yes. Please run the CLI with config-help -l csharp.

The default conditions in our templates are .NET 3.5 compatible. Options are passed to templates for additional features such as async support. We also pass additional properties such as net40 as helpers to indicate special cases. You can generate with debug flags enabled to see these template parameters.

@manuc66
Copy link
Contributor Author

manuc66 commented Nov 22, 2017

@jimschubert the nuget artifact is compatible with .NET 3.5 but on release v1.2.0 (see: https://www.nuget.org/packages/JsonSubTypes/1.2.0#show-dependency-groups)

I'll make another PR in order to handle .NET 3.5

@jimschubert
Copy link
Contributor

Cool. I didn't see that when I looked.

Are there API differences in usage between these versions? If not, it should just be a simple template switch in the project files, build script, and package file.

@manuc66
Copy link
Contributor Author

manuc66 commented Nov 23, 2017

@jimschubert There is no API differences in usage

@manuc66 manuc66 mentioned this pull request Nov 23, 2017
4 tasks
@manuc66 manuc66 deleted the feature/jsonsubtype-nuget branch December 21, 2017 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants