Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#][aspnet] Fix broken template directory for deprecated lang #4142

Merged
merged 1 commit into from
Nov 7, 2016

Conversation

jimschubert
Copy link
Contributor

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

When I opened #4011, I seem to have forgotten to point the deprecated aspnet5 generator to the renamed aspnetcore directory.

This is a one-line change to point to that renamed directory.

This can be tested by running the same code in ./bin/aspnetcore-petstore-server.sh but changing the language to the deprecated aspnet5.

See #4121.

@wing328 wing328 added this to the v2.2.2 milestone Nov 7, 2016
@wing328 wing328 merged commit ad17654 into swagger-api:master Nov 7, 2016
acramatte added a commit to comerge/swagger-codegen that referenced this pull request Nov 9, 2016
* upstream/master: (42 commits)
  add vendor extension to handle void response in jaxrs-cxf
  better handling of */*
  Select application/json content-type in python generated client, if */* is in the list of content-types
  update mxf4j sample
  [ObjC] Fix deprecated JSONModel API usage (swagger-api#4133)
  [aspnet5] Fix broken template directory for deprecated lang (swagger-api#4142)
  Add constructFromObject to Javascript enum generation. (swagger-api#4120)
  [Obj-c] Generated code documentation fixes (swagger-api#4130)
  Added QAdept to companies list
  added clarification for swagger-api#4138
  Default added sourceFolder to src/main/java
  Update pojo.mustache
  [feign] Use feign-form (swagger-api#4124)
  DART: Removed the 'justIgnoreThisFlag' flag (swagger-api#4116)
  fix[dart]: multi-word class names work properly now
  [ruby] Validate array correctly It never throws error with any values in array. Every element should be validated against the enum.
  remove glassfish dependencies and use MSF4J internal implementation for the simplicity and reduce dependencies
  updated to next development version
  Added isEmtyString check to avoid IndexOutOfBoundException
  Nancy fx work (swagger-api#4107)
  ...
@wing328 wing328 changed the title [aspnet5] Fix broken template directory for deprecated lang [C#][aspnet] Fix broken template directory for deprecated lang Feb 20, 2017
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants