Several minor fixes in the Go client code generator for Camelization of elements #2289
Conversation
|
@neilotoole yes, thank for the PR. Totally agree that we should have some test cases for Petstore GO API client. I created a task for tracking here: #1948 If you've cycle, we would appreciate your contribution on that. |
|
@wing328 Hopefully I'll have some free cycles coming up in the next few weeks. Do you have a general strategy for dealing with test harness runtimes? (Apologies, I haven't yet had a good look around the rest of the codebase). Given that this test harness would require the installation of the Go runtime, perhaps it should be done in a container? Or any other thoughts? |
Several minor fixes in the Go client code generator for Camelization of elements
|
For testing, travis-ci does not support multiple languages so we've to install the lang/package manually if it's required by the test. As an example, for ObjC/Swift, the tests are not run by the CI so currently I've to manually run the tests when reviewing changes related to ObjC/Swift. |
|
Hmmmn... well, in this era (so far! so soon!), any CI process worth its salt should allow one to kick off a container to execute tests? Concourse CI for example. With all the different runtime harnesses that codegen needs to support, this seems almost a determining factor for CI selection? |
|
I did reach out to other CI providers and hopefully they've better (and free) solution for our special case. |
|
Best of luck with that! Let me know if I can help. Containers are really the only way to go if you'd like to (ultimately) have full end-to-end test harnesses for each of the supported languages. It's effectively physically impossible to do it otherwise, and that's really what we should be aiming for. |
|
Totally agree. I'll share the update once I've more info. |
See issue #2285 for more details. This fix has been verified locally against a known good swagger file, and the generated client tested against just a handful of operations, so quality is not assured. From my quick look around there doesn't appear to be a Go test harness, I think that's something that we many need to work on. Apologies for any violations of style etc, feel free to edit as needed.