Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApiClient Bugfix: containsString removed to support iOS 7 #2210

Merged
merged 1 commit into from
Feb 23, 2016

Conversation

svenluzar
Copy link
Contributor

No description provided.

@wing328 wing328 added this to the v2.1.6 milestone Feb 22, 2016
@wing328
Copy link
Contributor

wing328 commented Feb 23, 2016

@svenluzar thanks for the PR. Please update the ObjC Petstore sample and also run the test locally to ensure all the test cases pass:

./bin/objc-petstore.sh
cd samples/client/petstore/objc/SwaggerClientTests
mvn integration-test

Ref: https://github.com/swagger-api/swagger-codegen/blob/master/CONTRIBUTING.md

@svenluzar
Copy link
Contributor Author

Thanks for your hint. What's the exact problem with my pull request? The tests already have executed with success.

** TEST SUCCEEDED **

16:57:50.373 xctest[14414:1293055] _XCT_testBundleReadyWithProtocolVersion:minimumVersion: reply received
16:57:50.377 xctest[14414:1293055] _IDE_startExecutingTestPlanWithProtocolVersion:16
Test Suite 'All tests' started at 2016-02-23 16:57:50.406
Test Suite 'SwaggerClient_Tests.xctest' started at 2016-02-23 16:57:50.407
Test Suite 'DeserializationTest' started at 2016-02-23 16:57:50.408
Test Case '-[DeserializationTest testDeserializeBool]' started.
Test Case '-[DeserializationTest testDeserializeBool]' passed (0.019 seconds).
Test Case '-[DeserializationTest testDeserializeDate]' started.
Test Case '-[DeserializationTest testDeserializeDate]' passed (0.003 seconds).
Test Case '-[DeserializationTest testDeserializeDateTime]' started.
Test Case '-[DeserializationTest testDeserializeDateTime]' passed (0.002 seconds).
Test Case '-[DeserializationTest testDeserializeListOfModels]' started.
Test Case '-[DeserializationTest testDeserializeListOfModels]' passed (0.003 seconds).
Test Case '-[DeserializationTest testDeserializeListOfString]' started.
Test Case '-[DeserializationTest testDeserializeListOfString]' passed (0.002 seconds).
Test Case '-[DeserializationTest testDeserializeMapOfModels]' started.
Test Case '-[DeserializationTest testDeserializeMapOfModels]' passed (0.002 seconds).
Test Case '-[DeserializationTest testDeserializeNestedList]' started.
Test Case '-[DeserializationTest testDeserializeNestedList]' passed (0.002 seconds).
Test Case '-[DeserializationTest testDeserializeNestedMap]' started.
Test Case '-[DeserializationTest testDeserializeNestedMap]' passed (0.002 seconds).
Test Case '-[DeserializationTest testDeserializeObject]' started.
Test Case '-[DeserializationTest testDeserializeObject]' passed (0.002 seconds).
Test Case '-[DeserializationTest testDeserializeString]' started.
Test Case '-[DeserializationTest testDeserializeString]' passed (0.002 seconds).
Test Suite 'DeserializationTest' passed at 2016-02-23 16:57:50.447.
Executed 10 tests, with 0 failures (0 unexpected) in 0.037 (0.040) seconds
Test Suite 'PetApiTest' started at 2016-02-23 16:57:50.448
Test Case '-[PetApiTest testCreateAndGetPet]' started.
2016-02-23 16:57:50.681 xctest[14414:1293050] 1456243070
Test Case '-[PetApiTest testCreateAndGetPet]' passed (0.457 seconds).
Test Case '-[PetApiTest testCreatePetApi]' started.
Test Case '-[PetApiTest testCreatePetApi]' passed (0.002 seconds).
Test Case '-[PetApiTest testDeletePet]' started.
Test Case '-[PetApiTest testDeletePet]' passed (0.666 seconds).
Test Case '-[PetApiTest testGetPetByTags]' started.
2016-02-23 16:57:51.574 xctest[14414:1293050] 1456243071
Test Case '-[PetApiTest testGetPetByTags]' passed (0.459 seconds).
Test Case '-[PetApiTest testUpdatePet]' started.
2016-02-23 16:57:52.472 xctest[14414:1293050] got the pet
Test Case '-[PetApiTest testUpdatePet]' passed (0.881 seconds).
Test Case '-[PetApiTest testUploadFile]' started.
Test Case '-[PetApiTest testUploadFile]' passed (0.225 seconds).
Test Case '-[PetApiTest testUploadFileWithFormParameter]' started.
Test Case '-[PetApiTest testUploadFileWithFormParameter]' passed (0.222 seconds).
Test Suite 'PetApiTest' passed at 2016-02-23 16:57:53.363.
Executed 7 tests, with 0 failures (0 unexpected) in 2.912 (2.915) seconds
Test Suite 'PetTest' started at 2016-02-23 16:57:53.367
Test Case '-[PetTest testDescription]' started.
Test Case '-[PetTest testDescription]' passed (0.001 seconds).
Test Suite 'PetTest' passed at 2016-02-23 16:57:53.368.
Executed 1 test, with 0 failures (0 unexpected) in 0.001 (0.001) seconds
Test Suite 'SWGApiClientTest' started at 2016-02-23 16:57:53.369
Test Case '-[SWGApiClientTest testConfiguration]' started.
Test Case '-[SWGApiClientTest testConfiguration]' passed (0.003 seconds).
Test Case '-[SWGApiClientTest testGetBasicAuthToken]' started.
Test Case '-[SWGApiClientTest testGetBasicAuthToken]' passed (0.002 seconds).
Test Case '-[SWGApiClientTest testSanitizeForSerialization]' started.
Test Case '-[SWGApiClientTest testSanitizeForSerialization]' passed (0.006 seconds).
Test Case '-[SWGApiClientTest testSelectHeaderAccept]' started.
Test Case '-[SWGApiClientTest testSelectHeaderAccept]' passed (0.002 seconds).
Test Case '-[SWGApiClientTest testSelectHeaderContentType]' started.
Test Case '-[SWGApiClientTest testSelectHeaderContentType]' passed (0.002 seconds).
Test Suite 'SWGApiClientTest' passed at 2016-02-23 16:57:53.386.
Executed 5 tests, with 0 failures (0 unexpected) in 0.015 (0.017) seconds
Test Suite 'StoreApiTest' started at 2016-02-23 16:57:53.386
Test Case '-[StoreApiTest testGetInventory]' started.
Test Case '-[StoreApiTest testGetInventory]' passed (0.220 seconds).
Test Suite 'StoreApiTest' passed at 2016-02-23 16:57:53.607.
Executed 1 test, with 0 failures (0 unexpected) in 0.220 (0.221) seconds
Test Suite 'UserApiTest' started at 2016-02-23 16:57:53.607
Test Case '-[UserApiTest testLoginUser]' started.
Test Case '-[UserApiTest testLoginUser]' passed (0.225 seconds).
Test Suite 'UserApiTest' passed at 2016-02-23 16:57:53.832.
Executed 1 test, with 0 failures (0 unexpected) in 0.225 (0.225) seconds
Test Suite 'SwaggerClient_Tests.xctest' passed at 2016-02-23 16:57:53.833.
Executed 25 tests, with 0 failures (0 unexpected) in 3.409 (3.426) seconds
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15.537 s
[INFO] Finished at: 2016-02-23T16:57:54+01:00
[INFO] Final Memory: 13M/309M
[INFO] ------------------------------------------------------------------------

@wing328
Copy link
Contributor

wing328 commented Feb 23, 2016

Sorry I was not clear. There's no problem with your PR. As part of the change process, we want the contributor to update the Petstore sample so that CI (travis) can test the change or the contributor can also verify the change themselves locally.

PR merged. Thanks for the contribution.

wing328 added a commit that referenced this pull request Feb 23, 2016
ApiClient Bugfix: containsString removed to support iOS 7
@wing328 wing328 merged commit 23696c5 into swagger-api:master Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants